admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: check for cargo build only in install method

Browse Source
This commit is contained in:
Dawid Dziurla 2023-08-18 11:20:56 +02:00 committed by GitHub
parent 5d4d674713
commit b4366b61ef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Library/Homebrew/rubocops/text.rb
View File

@ -56,6 +56,12 @@ module RuboCop
find_method_with_args(method_node, :system, "go", "get") do find_method_with_args(method_node, :system, "go", "get") do
problem "Do not use `go get`. Please ask upstream to implement Go vendoring" problem "Do not use `go get`. Please ask upstream to implement Go vendoring"
end end
find_method_with_args(method_node, :system, "cargo", "build") do |m|
next if parameters_passed?(m, [/--lib/])
problem "use \"cargo\", \"install\", *std_cargo_args"
end
end end
find_method_with_args(body_node, :system, "dep", "ensure") do |d| find_method_with_args(body_node, :system, "dep", "ensure") do |d|
@ -65,12 +71,6 @@ module RuboCop
problem "use \"dep\", \"ensure\", \"-vendor-only\"" problem "use \"dep\", \"ensure\", \"-vendor-only\""
end end
find_method_with_args(body_node, :system, "cargo", "build") do |m|
next if parameters_passed?(m, [/--lib/])
problem "use \"cargo\", \"install\", *std_cargo_args"
end
find_every_method_call_by_name(body_node, :system).each do |m| find_every_method_call_by_name(body_node, :system).each do |m|
next unless parameters_passed?(m, [/make && make/]) next unless parameters_passed?(m, [/make && make/])