From b4366b61ef51346de85b67abdc091a0d11087eee Mon Sep 17 00:00:00 2001 From: Dawid Dziurla Date: Fri, 18 Aug 2023 11:20:56 +0200 Subject: [PATCH] audit: check for cargo build only in install method --- Library/Homebrew/rubocops/text.rb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Library/Homebrew/rubocops/text.rb b/Library/Homebrew/rubocops/text.rb index 17b3ff2e3f..e1c1461da0 100644 --- a/Library/Homebrew/rubocops/text.rb +++ b/Library/Homebrew/rubocops/text.rb @@ -56,6 +56,12 @@ module RuboCop find_method_with_args(method_node, :system, "go", "get") do problem "Do not use `go get`. Please ask upstream to implement Go vendoring" end + + find_method_with_args(method_node, :system, "cargo", "build") do |m| + next if parameters_passed?(m, [/--lib/]) + + problem "use \"cargo\", \"install\", *std_cargo_args" + end end find_method_with_args(body_node, :system, "dep", "ensure") do |d| @@ -65,12 +71,6 @@ module RuboCop problem "use \"dep\", \"ensure\", \"-vendor-only\"" end - find_method_with_args(body_node, :system, "cargo", "build") do |m| - next if parameters_passed?(m, [/--lib/]) - - problem "use \"cargo\", \"install\", *std_cargo_args" - end - find_every_method_call_by_name(body_node, :system).each do |m| next unless parameters_passed?(m, [/make && make/])