add tests for man+'man[1-8]'
This commit is contained in:
		
							parent
							
								
									76f4eccdce
								
							
						
					
					
						commit
						af5cd1a1da
					
				@ -93,12 +93,12 @@ module RuboCop
 | 
			
		||||
              problem "Use build instead of ARGV to check options"
 | 
			
		||||
            end
 | 
			
		||||
          end
 | 
			
		||||
          #
 | 
			
		||||
          # find_instance_method_call(body_node, :man, :+) do |m|
 | 
			
		||||
          #   next unless match = regex_match_group(parameters(m).first, %r{man[1-8]})
 | 
			
		||||
          #   problem "\"#{m.source}\" should be \"#{match[1]}\""
 | 
			
		||||
          # end
 | 
			
		||||
          #
 | 
			
		||||
 | 
			
		||||
          find_instance_method_call(body_node, :man, :+) do |m|
 | 
			
		||||
            next unless match = regex_match_group(parameters(m).first, %r{man[1-8]})
 | 
			
		||||
            problem "\"#{m.source}\" should be \"#{match[0]}\""
 | 
			
		||||
          end
 | 
			
		||||
 | 
			
		||||
          # # Avoid hard-coding compilers
 | 
			
		||||
          # find_every_method_call_by_name(body_node, :system).each do |m|
 | 
			
		||||
          #   param = parameters(m).first
 | 
			
		||||
 | 
			
		||||
@ -835,6 +835,30 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
 | 
			
		||||
        expect_offense(expected, actual)
 | 
			
		||||
      end
 | 
			
		||||
    end
 | 
			
		||||
 | 
			
		||||
    it "with man+ " do
 | 
			
		||||
      source = <<-EOS.undent
 | 
			
		||||
        class Foo < Formula
 | 
			
		||||
          desc "foo"
 | 
			
		||||
          url 'http://example.com/foo-1.0.tgz'
 | 
			
		||||
          def test
 | 
			
		||||
            man1.install man+"man8" => "faad.1"
 | 
			
		||||
          end
 | 
			
		||||
        end
 | 
			
		||||
      EOS
 | 
			
		||||
 | 
			
		||||
      expected_offenses = [{  message: "\"man+\"man8\"\" should be \"man8\"",
 | 
			
		||||
                              severity: :convention,
 | 
			
		||||
                              line: 5,
 | 
			
		||||
                              column: 22,
 | 
			
		||||
                              source: source }]
 | 
			
		||||
 | 
			
		||||
      inspect_source(cop, source)
 | 
			
		||||
 | 
			
		||||
      expected_offenses.zip(cop.offenses).each do |expected, actual|
 | 
			
		||||
        expect_offense(expected, actual)
 | 
			
		||||
      end
 | 
			
		||||
    end
 | 
			
		||||
  end
 | 
			
		||||
  def expect_offense(expected, actual)
 | 
			
		||||
    expect(actual.message).to eq(expected[:message])
 | 
			
		||||
 | 
			
		||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user