add test for using ARGV to check options

This commit is contained in:
Gautham Goli 2017-08-14 15:22:44 +05:30
parent dc4d10ff6a
commit 76f4eccdce
2 changed files with 29 additions and 6 deletions

View File

@ -88,11 +88,11 @@ module RuboCop
end
end
# [:debug?, :verbose?, :value].each do |m|
# find_instance_method_call(body_node, :ARGV, m) do
# problem "Use build instead of ARGV to check options"
# end
# end
[:debug?, :verbose?, :value].each do |m|
find_instance_method_call(body_node, "ARGV", m) do
problem "Use build instead of ARGV to check options"
end
end
#
# find_instance_method_call(body_node, :man, :+) do |m|
# next unless match = regex_match_group(parameters(m).first, %r{man[1-8]})
@ -320,7 +320,6 @@ module RuboCop
next unless match = regex_match_group(arg, %r{\-\-(.*)})
problem "Reference '#{match[1]}' without dashes"
end
end
def unless_modifier?(node)

View File

@ -811,6 +811,30 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
expect_offense(expected, actual)
end
end
it "with using ARGV to check options" do
source = <<-EOS.undent
class Foo < Formula
desc "foo"
url 'http://example.com/foo-1.0.tgz'
def test
verbose = ARGV.verbose?
end
end
EOS
expected_offenses = [{ message: "Use build instead of ARGV to check options",
severity: :convention,
line: 5,
column: 14,
source: source }]
inspect_source(cop, source)
expected_offenses.zip(cop.offenses).each do |expected, actual|
expect_offense(expected, actual)
end
end
end
def expect_offense(expected, actual)
expect(actual.message).to eq(expected[:message])