From a398307612ebe504b7d7528cefc91ed480d0fe3d Mon Sep 17 00:00:00 2001
From: Elizabeth Tackett <emctackett@gmail.com>
Date: Tue, 30 Jun 2020 10:36:00 -0500
Subject: [PATCH] brew style fixes

---
 Library/Homebrew/utils/livecheck.rb |  8 ++++----
 Library/Homebrew/utils/repology.rb  | 19 ++++++++++---------
 Library/Homebrew/utils/versions.rb  |  4 ++--
 3 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/Library/Homebrew/utils/livecheck.rb b/Library/Homebrew/utils/livecheck.rb
index e590fc5ce6..4306793ac2 100644
--- a/Library/Homebrew/utils/livecheck.rb
+++ b/Library/Homebrew/utils/livecheck.rb
@@ -9,7 +9,7 @@ module Livecheck
       "brew",
       "livecheck",
       formula_name,
-      "--quiet"
+      "--quiet",
     ]
 
     response = Open3.capture2e(*command_args)
@@ -17,12 +17,12 @@ module Livecheck
   end
 
   def parse_livecheck_response(response)
-    output = response.first.gsub(" ", "").split(/:|==>|\n/)
+    output = response.first.delete(" ").split(/:|==>|\n/)
 
     # eg: ["burp", "2.2.18", "2.2.18"]
     package_name, brew_version, latest_version = output
 
-    {"name" => package_name, "current_brew_version" => brew_version,
-      "livecheck_latest_version" => latest_version}
+    { "name" => package_name, "current_brew_version" => brew_version,
+      "livecheck_latest_version" => latest_version }
   end
 end
diff --git a/Library/Homebrew/utils/repology.rb b/Library/Homebrew/utils/repology.rb
index a1a16a0152..bbe976a749 100644
--- a/Library/Homebrew/utils/repology.rb
+++ b/Library/Homebrew/utils/repology.rb
@@ -28,7 +28,7 @@ module RepologyParser
     last_package_index = outdated_packages.size - 1
     response_size = outdated_packages.size
 
-    while response_size > 1 do
+    while response_size > 1
       page_no += 1
       ohai "\n- Paginating repology api page: #{page_no}"
 
@@ -45,27 +45,28 @@ module RepologyParser
     outdated_packages
   end
 
-  def validate__repology_packages(outdated_repology_packages, brew_formulas)
+  def validate__repology_packages(outdated_repology_packages)
     ohai "\n- Verify Outdated Repology Packages as Homebrew Formulae"
 
     packages = {}
 
-    outdated_repology_packages.each do |name, repositories|
+    outdated_repology_packages.each do |_name, repositories|
       # identify homebrew repo
-      repology_homebrew_repo = repositories.select do
-         |repo| repo["repo"] == "homebrew"
-      end.first
+      repology_homebrew_repo = repositories.find do |repo|
+        repo["repo"] == "homebrew"
+      end
 
       next if repology_homebrew_repo.empty?
+
       latest_version = nil
 
-      #identify latest version amongst repology repos
+      # identify latest version amongst repology repos
       repositories.each do |repo|
         latest_version = repo["version"] if repo["status"] == "newest"
       end
 
-      packages[repology_homebrew_repo['srcname']] = {
-        'repology_latest_version' => latest_version,
+      packages[repology_homebrew_repo["srcname"]] = {
+        "repology_latest_version" => latest_version,
       }
     end
     # hash of hashes {'openclonk' => {repology_latest_version => 7.0}, ..}
diff --git a/Library/Homebrew/utils/versions.rb b/Library/Homebrew/utils/versions.rb
index da017441f2..0155f1a0cf 100644
--- a/Library/Homebrew/utils/versions.rb
+++ b/Library/Homebrew/utils/versions.rb
@@ -22,8 +22,8 @@ module Versions
     parse_formula_bump_response(response)
   end
 
-  def parse_formula_bump_response(response)
-    response, status  = formula_bump_response
+  def parse_formula_bump_response(formula_bump_response)
+    response, _status = formula_bump_response
     response
   end