admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: flag incorrect automake/autoconf/libtool dep handling

Browse Source 
Just makes the audit cough out this:
```
 * :libtool is deprecated. Usage should be "libtool"
 * :autoconf is deprecated. Usage should be "autoconf"
 * :automake is deprecated. Usage should be "automake"
```

Closes Homebrew/homebrew#39303.
Closes Homebrew/homebrew#39322.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This commit is contained in:
Dominyk Tiller 2015-05-03 18:52:46 +01:00 committed by Jack Nagel
parent 241831e263
commit 9dc8db12e4
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/cmd/audit.rb
View File

@ -588,6 +588,10 @@ class FormulaAuditor
problem "\"#{$1}\" should be \"\#{#{$2}}\"" problem "\"#{$1}\" should be \"\#{#{$2}}\""
end end
if line =~ %r[depends_on :(automake|autoconf|libtool)]
problem ":#{$1} is deprecated. Usage should be \"#{$1}\""
end
# Commented-out depends_on # Commented-out depends_on
if line =~ /#\s*depends_on\s+(.+)\s*$/ if line =~ /#\s*depends_on\s+(.+)\s*$/
problem "Commented-out dep #{$1}" problem "Commented-out dep #{$1}"