From 9dc8db12e4a9f342acc5b3611f5231b6c38ba81a Mon Sep 17 00:00:00 2001 From: Dominyk Tiller Date: Sun, 3 May 2015 18:52:46 +0100 Subject: [PATCH] audit: flag incorrect automake/autoconf/libtool dep handling Just makes the audit cough out this: ``` * :libtool is deprecated. Usage should be "libtool" * :autoconf is deprecated. Usage should be "autoconf" * :automake is deprecated. Usage should be "automake" ``` Closes Homebrew/homebrew#39303. Closes Homebrew/homebrew#39322. Signed-off-by: Jack Nagel --- Library/Homebrew/cmd/audit.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index 45502d865b..2d61a4c7d4 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -588,6 +588,10 @@ class FormulaAuditor problem "\"#{$1}\" should be \"\#{#{$2}}\"" end + if line =~ %r[depends_on :(automake|autoconf|libtool)] + problem ":#{$1} is deprecated. Usage should be \"#{$1}\"" + end + # Commented-out depends_on if line =~ /#\s*depends_on\s+(.+)\s*$/ problem "Commented-out dep #{$1}"