Use @min_named_args to generate argv

This commit is contained in:
Douglas Eichelberger 2024-03-21 19:48:13 -07:00
parent 26b3f30bba
commit 97370b4e6a
12 changed files with 14 additions and 12 deletions

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true # frozen_string_literal: true
RSpec.shared_examples "parseable arguments" do |argv: []| RSpec.shared_examples "parseable arguments" do |argv: nil|
subject(:method_name) { "#{command_name.tr("-", "_")}_args" } subject(:method_name) { "#{command_name.tr("-", "_")}_args" }
let(:command_name) do |example| let(:command_name) do |example|
@ -9,6 +9,8 @@ RSpec.shared_examples "parseable arguments" do |argv: []|
it "can parse arguments" do it "can parse arguments" do
if described_class if described_class
argv ||= described_class.parser.instance_variable_get(:@min_named_args)&.times&.map { "argument" }
argv ||= []
cmd = described_class.new(argv) cmd = described_class.new(argv)
expect(cmd.args).to be_a Homebrew::CLI::Args expect(cmd.args).to be_a Homebrew::CLI::Args
else else

View File

@ -30,7 +30,7 @@ RSpec.describe Homebrew::DevCmd::Bottle do
EOS EOS
end end
it_behaves_like "parseable arguments", argv: ["foo"] it_behaves_like "parseable arguments"
it "builds a bottle for the given Formula", :integration_test do it "builds a bottle for the given Formula", :integration_test do
install_test_formula "testball", build_bottle: true install_test_formula "testball", build_bottle: true

View File

@ -4,5 +4,5 @@ require "cmd/shared_examples/args_parse"
require "dev-cmd/bump-cask-pr" require "dev-cmd/bump-cask-pr"
RSpec.describe Homebrew::DevCmd::BumpCaskPr do RSpec.describe Homebrew::DevCmd::BumpCaskPr do
it_behaves_like "parseable arguments", argv: ["foo"] it_behaves_like "parseable arguments"
end end

View File

@ -4,5 +4,5 @@ require "cmd/shared_examples/args_parse"
require "dev-cmd/bump-revision" require "dev-cmd/bump-revision"
RSpec.describe Homebrew::DevCmd::BumpRevision do RSpec.describe Homebrew::DevCmd::BumpRevision do
it_behaves_like "parseable arguments", argv: ["foo"] it_behaves_like "parseable arguments"
end end

View File

@ -4,5 +4,5 @@ require "cmd/shared_examples/args_parse"
require "dev-cmd/bump-unversioned-casks" require "dev-cmd/bump-unversioned-casks"
RSpec.describe Homebrew::DevCmd::BumpUnversionedCasks do RSpec.describe Homebrew::DevCmd::BumpUnversionedCasks do
it_behaves_like "parseable arguments", argv: ["foo"] it_behaves_like "parseable arguments"
end end

View File

@ -4,7 +4,7 @@ require "cmd/shared_examples/args_parse"
require "dev-cmd/cat" require "dev-cmd/cat"
RSpec.describe Homebrew::DevCmd::Cat do RSpec.describe Homebrew::DevCmd::Cat do
it_behaves_like "parseable arguments", argv: ["foo"] it_behaves_like "parseable arguments"
it "prints the content of a given Formula", :integration_test do it "prints the content of a given Formula", :integration_test do
formula_file = setup_test_formula "testball" formula_file = setup_test_formula "testball"

View File

@ -4,7 +4,7 @@ require "cmd/shared_examples/args_parse"
require "dev-cmd/command" require "dev-cmd/command"
RSpec.describe Homebrew::DevCmd::Command do RSpec.describe Homebrew::DevCmd::Command do
it_behaves_like "parseable arguments", argv: ["foo"] it_behaves_like "parseable arguments"
it "returns the file for a given command", :integration_test do it "returns the file for a given command", :integration_test do
expect { brew "command", "info" } expect { brew "command", "info" }

View File

@ -7,7 +7,7 @@ RSpec.describe Homebrew::DevCmd::Create do
let(:url) { "file://#{TEST_FIXTURE_DIR}/tarballs/testball-0.1.tbz" } let(:url) { "file://#{TEST_FIXTURE_DIR}/tarballs/testball-0.1.tbz" }
let(:formula_file) { CoreTap.instance.new_formula_path("testball") } let(:formula_file) { CoreTap.instance.new_formula_path("testball") }
it_behaves_like "parseable arguments", argv: ["foo"] it_behaves_like "parseable arguments"
it "creates a new Formula file for a given URL", :integration_test do it "creates a new Formula file for a given URL", :integration_test do
brew "create", "--set-name=Testball", url, "HOMEBREW_EDITOR" => "/bin/cat" brew "create", "--set-name=Testball", url, "HOMEBREW_EDITOR" => "/bin/cat"

View File

@ -4,5 +4,5 @@ require "cmd/shared_examples/args_parse"
require "dev-cmd/dispatch-build-bottle" require "dev-cmd/dispatch-build-bottle"
RSpec.describe Homebrew::DevCmd::DispatchBuildBottle do RSpec.describe Homebrew::DevCmd::DispatchBuildBottle do
it_behaves_like "parseable arguments", argv: ["foo"] it_behaves_like "parseable arguments"
end end

View File

@ -4,7 +4,7 @@ require "cmd/shared_examples/args_parse"
require "dev-cmd/extract" require "dev-cmd/extract"
RSpec.describe Homebrew::DevCmd::Extract do RSpec.describe Homebrew::DevCmd::Extract do
it_behaves_like "parseable arguments", argv: ["foo", "bar"] it_behaves_like "parseable arguments"
context "when extracting a formula" do context "when extracting a formula" do
let!(:target) do let!(:target) do

View File

@ -4,7 +4,7 @@ require "cmd/shared_examples/args_parse"
require "dev-cmd/formula" require "dev-cmd/formula"
RSpec.describe Homebrew::DevCmd::FormulaCmd do RSpec.describe Homebrew::DevCmd::FormulaCmd do
it_behaves_like "parseable arguments", argv: ["foo"] it_behaves_like "parseable arguments"
it "prints a given Formula's path", :integration_test do it "prints a given Formula's path", :integration_test do
formula_file = setup_test_formula "testball" formula_file = setup_test_formula "testball"

View File

@ -4,5 +4,5 @@ require "cmd/shared_examples/args_parse"
require "dev-cmd/pr-publish" require "dev-cmd/pr-publish"
RSpec.describe Homebrew::DevCmd::PrPublish do RSpec.describe Homebrew::DevCmd::PrPublish do
it_behaves_like "parseable arguments", argv: ["foo"] it_behaves_like "parseable arguments"
end end