diff --git a/Library/Homebrew/test/cmd/shared_examples/args_parse.rb b/Library/Homebrew/test/cmd/shared_examples/args_parse.rb index b2a89271ae..865f480013 100644 --- a/Library/Homebrew/test/cmd/shared_examples/args_parse.rb +++ b/Library/Homebrew/test/cmd/shared_examples/args_parse.rb @@ -1,6 +1,6 @@ # frozen_string_literal: true -RSpec.shared_examples "parseable arguments" do |argv: []| +RSpec.shared_examples "parseable arguments" do |argv: nil| subject(:method_name) { "#{command_name.tr("-", "_")}_args" } let(:command_name) do |example| @@ -9,6 +9,8 @@ RSpec.shared_examples "parseable arguments" do |argv: []| it "can parse arguments" do if described_class + argv ||= described_class.parser.instance_variable_get(:@min_named_args)&.times&.map { "argument" } + argv ||= [] cmd = described_class.new(argv) expect(cmd.args).to be_a Homebrew::CLI::Args else diff --git a/Library/Homebrew/test/dev-cmd/bottle_spec.rb b/Library/Homebrew/test/dev-cmd/bottle_spec.rb index 58dbd58cc6..d646e6b1d5 100644 --- a/Library/Homebrew/test/dev-cmd/bottle_spec.rb +++ b/Library/Homebrew/test/dev-cmd/bottle_spec.rb @@ -30,7 +30,7 @@ RSpec.describe Homebrew::DevCmd::Bottle do EOS end - it_behaves_like "parseable arguments", argv: ["foo"] + it_behaves_like "parseable arguments" it "builds a bottle for the given Formula", :integration_test do install_test_formula "testball", build_bottle: true diff --git a/Library/Homebrew/test/dev-cmd/bump-cask-pr_spec.rb b/Library/Homebrew/test/dev-cmd/bump-cask-pr_spec.rb index 8454650c9d..7c0a5afa97 100644 --- a/Library/Homebrew/test/dev-cmd/bump-cask-pr_spec.rb +++ b/Library/Homebrew/test/dev-cmd/bump-cask-pr_spec.rb @@ -4,5 +4,5 @@ require "cmd/shared_examples/args_parse" require "dev-cmd/bump-cask-pr" RSpec.describe Homebrew::DevCmd::BumpCaskPr do - it_behaves_like "parseable arguments", argv: ["foo"] + it_behaves_like "parseable arguments" end diff --git a/Library/Homebrew/test/dev-cmd/bump-revision_spec.rb b/Library/Homebrew/test/dev-cmd/bump-revision_spec.rb index 10c2646451..e6d8d516cc 100644 --- a/Library/Homebrew/test/dev-cmd/bump-revision_spec.rb +++ b/Library/Homebrew/test/dev-cmd/bump-revision_spec.rb @@ -4,5 +4,5 @@ require "cmd/shared_examples/args_parse" require "dev-cmd/bump-revision" RSpec.describe Homebrew::DevCmd::BumpRevision do - it_behaves_like "parseable arguments", argv: ["foo"] + it_behaves_like "parseable arguments" end diff --git a/Library/Homebrew/test/dev-cmd/bump-unversioned-casks_spec.rb b/Library/Homebrew/test/dev-cmd/bump-unversioned-casks_spec.rb index f6c6936307..48250d51d4 100644 --- a/Library/Homebrew/test/dev-cmd/bump-unversioned-casks_spec.rb +++ b/Library/Homebrew/test/dev-cmd/bump-unversioned-casks_spec.rb @@ -4,5 +4,5 @@ require "cmd/shared_examples/args_parse" require "dev-cmd/bump-unversioned-casks" RSpec.describe Homebrew::DevCmd::BumpUnversionedCasks do - it_behaves_like "parseable arguments", argv: ["foo"] + it_behaves_like "parseable arguments" end diff --git a/Library/Homebrew/test/dev-cmd/cat_spec.rb b/Library/Homebrew/test/dev-cmd/cat_spec.rb index b00cd32f81..b3789b8856 100644 --- a/Library/Homebrew/test/dev-cmd/cat_spec.rb +++ b/Library/Homebrew/test/dev-cmd/cat_spec.rb @@ -4,7 +4,7 @@ require "cmd/shared_examples/args_parse" require "dev-cmd/cat" RSpec.describe Homebrew::DevCmd::Cat do - it_behaves_like "parseable arguments", argv: ["foo"] + it_behaves_like "parseable arguments" it "prints the content of a given Formula", :integration_test do formula_file = setup_test_formula "testball" diff --git a/Library/Homebrew/test/dev-cmd/command_spec.rb b/Library/Homebrew/test/dev-cmd/command_spec.rb index 1ea4ef9265..d5751e5dd4 100644 --- a/Library/Homebrew/test/dev-cmd/command_spec.rb +++ b/Library/Homebrew/test/dev-cmd/command_spec.rb @@ -4,7 +4,7 @@ require "cmd/shared_examples/args_parse" require "dev-cmd/command" RSpec.describe Homebrew::DevCmd::Command do - it_behaves_like "parseable arguments", argv: ["foo"] + it_behaves_like "parseable arguments" it "returns the file for a given command", :integration_test do expect { brew "command", "info" } diff --git a/Library/Homebrew/test/dev-cmd/create_spec.rb b/Library/Homebrew/test/dev-cmd/create_spec.rb index 35e16e78c3..f1cd4b526a 100644 --- a/Library/Homebrew/test/dev-cmd/create_spec.rb +++ b/Library/Homebrew/test/dev-cmd/create_spec.rb @@ -7,7 +7,7 @@ RSpec.describe Homebrew::DevCmd::Create do let(:url) { "file://#{TEST_FIXTURE_DIR}/tarballs/testball-0.1.tbz" } let(:formula_file) { CoreTap.instance.new_formula_path("testball") } - it_behaves_like "parseable arguments", argv: ["foo"] + it_behaves_like "parseable arguments" it "creates a new Formula file for a given URL", :integration_test do brew "create", "--set-name=Testball", url, "HOMEBREW_EDITOR" => "/bin/cat" diff --git a/Library/Homebrew/test/dev-cmd/dispatch-build-bottle_spec.rb b/Library/Homebrew/test/dev-cmd/dispatch-build-bottle_spec.rb index 64ccb1b353..84c329bc3b 100644 --- a/Library/Homebrew/test/dev-cmd/dispatch-build-bottle_spec.rb +++ b/Library/Homebrew/test/dev-cmd/dispatch-build-bottle_spec.rb @@ -4,5 +4,5 @@ require "cmd/shared_examples/args_parse" require "dev-cmd/dispatch-build-bottle" RSpec.describe Homebrew::DevCmd::DispatchBuildBottle do - it_behaves_like "parseable arguments", argv: ["foo"] + it_behaves_like "parseable arguments" end diff --git a/Library/Homebrew/test/dev-cmd/extract_spec.rb b/Library/Homebrew/test/dev-cmd/extract_spec.rb index 9643529ddc..f6e6104255 100644 --- a/Library/Homebrew/test/dev-cmd/extract_spec.rb +++ b/Library/Homebrew/test/dev-cmd/extract_spec.rb @@ -4,7 +4,7 @@ require "cmd/shared_examples/args_parse" require "dev-cmd/extract" RSpec.describe Homebrew::DevCmd::Extract do - it_behaves_like "parseable arguments", argv: ["foo", "bar"] + it_behaves_like "parseable arguments" context "when extracting a formula" do let!(:target) do diff --git a/Library/Homebrew/test/dev-cmd/formula_spec.rb b/Library/Homebrew/test/dev-cmd/formula_spec.rb index 722580631d..59acf64bfa 100644 --- a/Library/Homebrew/test/dev-cmd/formula_spec.rb +++ b/Library/Homebrew/test/dev-cmd/formula_spec.rb @@ -4,7 +4,7 @@ require "cmd/shared_examples/args_parse" require "dev-cmd/formula" RSpec.describe Homebrew::DevCmd::FormulaCmd do - it_behaves_like "parseable arguments", argv: ["foo"] + it_behaves_like "parseable arguments" it "prints a given Formula's path", :integration_test do formula_file = setup_test_formula "testball" diff --git a/Library/Homebrew/test/dev-cmd/pr-publish_spec.rb b/Library/Homebrew/test/dev-cmd/pr-publish_spec.rb index 5c643b6a58..66384ab898 100644 --- a/Library/Homebrew/test/dev-cmd/pr-publish_spec.rb +++ b/Library/Homebrew/test/dev-cmd/pr-publish_spec.rb @@ -4,5 +4,5 @@ require "cmd/shared_examples/args_parse" require "dev-cmd/pr-publish" RSpec.describe Homebrew::DevCmd::PrPublish do - it_behaves_like "parseable arguments", argv: ["foo"] + it_behaves_like "parseable arguments" end