From 1775c32210021b76278c24f0c48f95e26a0ab4a2 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Fri, 21 Apr 2017 13:15:27 +0100 Subject: [PATCH] audit: new formulae should not require patches. We may under some circumstances accept these anyway but it's better to nudge people into the right behaviours on local `audit`s. --- Library/Homebrew/dev-cmd/audit.rb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index 4871cc8b2d..35798391e2 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -732,7 +732,10 @@ class FormulaAuditor } end + next if spec.patches.empty? spec.patches.each { |p| patch_problems(p) if p.external? } + next unless @new_formula + problem "New formulae should not require patches to build. Patches should be submitted and accepted upstream first." end %w[Stable Devel].each do |name|