admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

dev-cmd/typecheck: Stop dry running Spoom sigil bumps

Browse Source 
- Sixteen months ago in PR 14921, I made it so that CI ran
  `brew typecheck --update --suggest-typed` and could commit the changes.
- Except it never actually ever made any changes because of the `--dry` option
  in the Spoom CLI args. Whoops!
This commit is contained in:
Issy Long 2024-07-03 22:15:31 +00:00 committed by GitHub
parent f25e66754d
commit 79ab11c62d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/dev-cmd/typecheck.rb
View File

@ -60,9 +60,9 @@ module Homebrew
if args.suggest_typed? if args.suggest_typed?
ohai "Checking if we can bump Sorbet `typed` sigils..." ohai "Checking if we can bump Sorbet `typed` sigils..."
# --sorbet needed because of https://github.com/Shopify/spoom/issues/488 # --sorbet needed because of https://github.com/Shopify/spoom/issues/488
safe_system "bundle", "exec", "spoom", "srb", "bump", "--dry", "--from", "false", "--to", "true", safe_system "bundle", "exec", "spoom", "srb", "bump", "--from", "false", "--to", "true",
"--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc" "--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc"
safe_system "bundle", "exec", "spoom", "srb", "bump", "--dry", "--from", "true", "--to", "strict", safe_system "bundle", "exec", "spoom", "srb", "bump", "--from", "true", "--to", "strict",
"--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc" "--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc"
end end