From 79ab11c62db5afc59ce22d77019685d926868c66 Mon Sep 17 00:00:00 2001 From: Issy Long Date: Wed, 3 Jul 2024 22:15:31 +0000 Subject: [PATCH] dev-cmd/typecheck: Stop dry running Spoom sigil bumps - Sixteen months ago in PR 14921, I made it so that CI ran `brew typecheck --update --suggest-typed` and could commit the changes. - Except it never actually ever made any changes because of the `--dry` option in the Spoom CLI args. Whoops! --- Library/Homebrew/dev-cmd/typecheck.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/dev-cmd/typecheck.rb b/Library/Homebrew/dev-cmd/typecheck.rb index d87e54bfb2..272a9ed285 100644 --- a/Library/Homebrew/dev-cmd/typecheck.rb +++ b/Library/Homebrew/dev-cmd/typecheck.rb @@ -60,9 +60,9 @@ module Homebrew if args.suggest_typed? ohai "Checking if we can bump Sorbet `typed` sigils..." # --sorbet needed because of https://github.com/Shopify/spoom/issues/488 - safe_system "bundle", "exec", "spoom", "srb", "bump", "--dry", "--from", "false", "--to", "true", + safe_system "bundle", "exec", "spoom", "srb", "bump", "--from", "false", "--to", "true", "--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc" - safe_system "bundle", "exec", "spoom", "srb", "bump", "--dry", "--from", "true", "--to", "strict", + safe_system "bundle", "exec", "spoom", "srb", "bump", "--from", "true", "--to", "strict", "--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc" end