rubocop: exclude formula.rb from ClassLength.

We want to allow this class to grow larger still while still enforcing
this on other classes.
This commit is contained in:
Mike McQuaid 2020-08-04 14:03:11 +01:00
parent 361b92a32d
commit 754beb64fc
No known key found for this signature in database
GPG Key ID: 48A898132FD8EE70
3 changed files with 14 additions and 10 deletions

View File

@ -161,7 +161,6 @@ Lint/AmbiguousRegexpLiteral:
Lint/ParenthesesAsGroupedExpression: Lint/ParenthesesAsGroupedExpression:
Enabled: false Enabled: false
# most metrics don't make sense to apply for formulae/taps # most metrics don't make sense to apply for formulae/taps
Metrics/AbcSize: Metrics/AbcSize:
Enabled: false Enabled: false

View File

@ -20,6 +20,8 @@ Cask/StanzaOrder:
Description: 'Ensure that cask stanzas are sorted correctly. More info at https://github.com/Homebrew/homebrew-cask/blob/HEAD/CONTRIBUTING.md#stanza-order' Description: 'Ensure that cask stanzas are sorted correctly. More info at https://github.com/Homebrew/homebrew-cask/blob/HEAD/CONTRIBUTING.md#stanza-order'
Enabled: true Enabled: true
# don't want this for casks but re-enabled for Library/Homebrew # don't want these for casks but re-enabled for Library/Homebrew
Style/FrozenStringLiteralComment: Style/FrozenStringLiteralComment:
Enabled: false Enabled: false
Metrics/BlockLength:
Enabled: false

View File

@ -37,30 +37,33 @@ Lint/ParenthesesAsGroupedExpression:
# TODO: try to bring down all metrics maximums # TODO: try to bring down all metrics maximums
Metrics/AbcSize: Metrics/AbcSize:
Enabled: true Enabled: true
Max: 275 Max: 250
Metrics/BlockLength: Metrics/BlockLength:
Enabled: true Enabled: true
Max: 1100 Max: 100
Exclude: Exclude:
- 'test/formula_spec.rb' - 'test/**/*'
Metrics/BlockNesting: Metrics/BlockNesting:
Enabled: true Enabled: true
Max: 5 Max: 5
Metrics/ClassLength: Metrics/ClassLength:
Enabled: true Enabled: true
Max: 1400 Max: 800
Exclude:
- 'formula.rb'
- 'formula_installer.rb'
Metrics/CyclomaticComplexity: Metrics/CyclomaticComplexity:
Enabled: true Enabled: true
Max: 85 Max: 80
Metrics/MethodLength: Metrics/MethodLength:
Enabled: true Enabled: true
Max: 300 Max: 260
Metrics/ModuleLength: Metrics/ModuleLength:
Enabled: true Enabled: true
Max: 550 Max: 500
Metrics/PerceivedComplexity: Metrics/PerceivedComplexity:
Enabled: true Enabled: true
Max: 100 Max: 80
# we won't change backward compatible predicate names # we won't change backward compatible predicate names
Naming/PredicateName: Naming/PredicateName: