diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml index d8d0fdcedb..d741c7e09c 100644 --- a/Library/.rubocop.yml +++ b/Library/.rubocop.yml @@ -161,7 +161,6 @@ Lint/AmbiguousRegexpLiteral: Lint/ParenthesesAsGroupedExpression: Enabled: false - # most metrics don't make sense to apply for formulae/taps Metrics/AbcSize: Enabled: false diff --git a/Library/.rubocop_cask.yml b/Library/.rubocop_cask.yml index e53db5a55d..fe874e591c 100644 --- a/Library/.rubocop_cask.yml +++ b/Library/.rubocop_cask.yml @@ -20,6 +20,8 @@ Cask/StanzaOrder: Description: 'Ensure that cask stanzas are sorted correctly. More info at https://github.com/Homebrew/homebrew-cask/blob/HEAD/CONTRIBUTING.md#stanza-order' Enabled: true -# don't want this for casks but re-enabled for Library/Homebrew +# don't want these for casks but re-enabled for Library/Homebrew Style/FrozenStringLiteralComment: Enabled: false +Metrics/BlockLength: + Enabled: false diff --git a/Library/Homebrew/.rubocop.yml b/Library/Homebrew/.rubocop.yml index cca1eb3204..ba7e43870a 100644 --- a/Library/Homebrew/.rubocop.yml +++ b/Library/Homebrew/.rubocop.yml @@ -37,30 +37,33 @@ Lint/ParenthesesAsGroupedExpression: # TODO: try to bring down all metrics maximums Metrics/AbcSize: Enabled: true - Max: 275 + Max: 250 Metrics/BlockLength: Enabled: true - Max: 1100 + Max: 100 Exclude: - - 'test/formula_spec.rb' + - 'test/**/*' Metrics/BlockNesting: Enabled: true Max: 5 Metrics/ClassLength: Enabled: true - Max: 1400 + Max: 800 + Exclude: + - 'formula.rb' + - 'formula_installer.rb' Metrics/CyclomaticComplexity: Enabled: true - Max: 85 + Max: 80 Metrics/MethodLength: Enabled: true - Max: 300 + Max: 260 Metrics/ModuleLength: Enabled: true - Max: 550 + Max: 500 Metrics/PerceivedComplexity: Enabled: true - Max: 100 + Max: 80 # we won't change backward compatible predicate names Naming/PredicateName: