admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Remove redundant check in formula_files and cask_files

Browse Source 
Formula_files consists of every non-recursive child of formula_dir,
for which formula_file? evaluates to true. formula_file? checks if the file
is a child of formula_dir, which it is by definition. It turns out that by
removing the check, the time used for 'brew search' decreased from 800 ms to
700 ms, noticably faster during tab completion. The same happens with
cask_files and cask_file?
This commit is contained in:
Emiel Wiedijk 2018-10-06 17:29:34 +02:00
parent cf1c951e2f
commit 6ac30826d0
No known key found for this signature in database
GPG Key ID: 964A91B83275C836
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/tap.rb
View File

@ -382,7 +382,7 @@ class Tap
# an array of all {Formula} files of this {Tap}. # an array of all {Formula} files of this {Tap}.
def formula_files def formula_files
@formula_files ||= if formula_dir.directory? @formula_files ||= if formula_dir.directory?
formula_dir.children.select(&method(:formula_file?)) formula_dir.children.select { |file| file.extname == ".rb" }
else else
[] []
end end
@ -391,7 +391,7 @@ class Tap
# an array of all {Cask} files of this {Tap}. # an array of all {Cask} files of this {Tap}.
def cask_files def cask_files
@cask_files ||= if cask_dir.directory? @cask_files ||= if cask_dir.directory?
cask_dir.children.select(&method(:cask_file?)) cask_dir.children.select { |file| file.extname == ".rb" }
else else
[] []
end end