From 6ac30826d007089be67518f14401d7b290ebb5d7 Mon Sep 17 00:00:00 2001 From: Emiel Wiedijk Date: Sat, 6 Oct 2018 17:29:34 +0200 Subject: [PATCH] Remove redundant check in formula_files and cask_files Formula_files consists of every non-recursive child of formula_dir, for which formula_file? evaluates to true. formula_file? checks if the file is a child of formula_dir, which it is by definition. It turns out that by removing the check, the time used for 'brew search' decreased from 800 ms to 700 ms, noticably faster during tab completion. The same happens with cask_files and cask_file? --- Library/Homebrew/tap.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/tap.rb b/Library/Homebrew/tap.rb index 46160175e5..37534e5312 100644 --- a/Library/Homebrew/tap.rb +++ b/Library/Homebrew/tap.rb @@ -382,7 +382,7 @@ class Tap # an array of all {Formula} files of this {Tap}. def formula_files @formula_files ||= if formula_dir.directory? - formula_dir.children.select(&method(:formula_file?)) + formula_dir.children.select { |file| file.extname == ".rb" } else [] end @@ -391,7 +391,7 @@ class Tap # an array of all {Cask} files of this {Tap}. def cask_files @cask_files ||= if cask_dir.directory? - cask_dir.children.select(&method(:cask_file?)) + cask_dir.children.select { |file| file.extname == ".rb" } else [] end