audit: prefer modifying ENV to using env or export

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This commit is contained in:
Jack Nagel 2012-06-17 17:59:30 -05:00
parent 38a28285a6
commit 6a94df360a

View File

@ -129,6 +129,10 @@ def audit_formula_text name, text
problems << " * Use \"\#{ENV.cxx}\" instead of hard-coding \"#{$3}\"" problems << " * Use \"\#{ENV.cxx}\" instead of hard-coding \"#{$3}\""
end end
if text =~ /system\s+['"](env|export)/
problems << " * Use ENV instead of invoking '#{$1}' to modify the environment"
end
return problems return problems
end end