From 6a94df360a236acf23b025fdf3ca84f76f195c94 Mon Sep 17 00:00:00 2001
From: Jack Nagel <jacknagel@gmail.com>
Date: Sun, 17 Jun 2012 17:59:30 -0500
Subject: [PATCH] audit: prefer modifying ENV to using env or export

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
---
 Library/Homebrew/cmd/audit.rb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb
index 4ca541a75c..cb7cb2510e 100755
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@@ -129,6 +129,10 @@ def audit_formula_text name, text
     problems << " * Use \"\#{ENV.cxx}\" instead of hard-coding \"#{$3}\""
   end
 
+  if text =~ /system\s+['"](env|export)/
+    problems << " * Use ENV instead of invoking '#{$1}' to modify the environment"
+  end
+
   return problems
 end