rubocop: Drop "a" and "b" from Naming/MethodParameterName allowlist

This commit is contained in:
Issy Long 2023-03-11 00:04:10 +00:00
parent e9d994622e
commit 60d93310af
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
3 changed files with 7 additions and 9 deletions

View File

@ -189,8 +189,6 @@ Naming/MethodParameterName:
- AllowedNames - AllowedNames
AllowedNames: AllowedNames:
[ [
"a",
"b",
"o", "o",
"pr", "pr",
] ]

View File

@ -423,13 +423,13 @@ module Homebrew
end end
end end
def depends_on(a, b) def depends_on(one, two)
if a.any_installed_keg if one.any_installed_keg
&.runtime_dependencies &.runtime_dependencies
&.any? { |d| d["full_name"] == b.full_name } &.any? { |dependency| dependency["full_name"] == two.full_name }
1 1
else else
a <=> b one <=> two
end end
end end
private_class_method :depends_on private_class_method :depends_on

View File

@ -653,9 +653,9 @@ class Version
private private
sig { params(a: Integer, b: Integer).returns(Integer) } sig { params(first: Integer, second: Integer).returns(Integer) }
def max(a, b) def max(first, second)
(a > b) ? a : b (first > second) ? first : second
end end
sig { returns(T::Array[Token]) } sig { returns(T::Array[Token]) }