diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml index 8d2bc7a337..e973eb6bc2 100644 --- a/Library/.rubocop.yml +++ b/Library/.rubocop.yml @@ -189,8 +189,6 @@ Naming/MethodParameterName: - AllowedNames AllowedNames: [ - "a", - "b", "o", "pr", ] diff --git a/Library/Homebrew/upgrade.rb b/Library/Homebrew/upgrade.rb index 9875779275..83fe6329e2 100644 --- a/Library/Homebrew/upgrade.rb +++ b/Library/Homebrew/upgrade.rb @@ -423,13 +423,13 @@ module Homebrew end end - def depends_on(a, b) - if a.any_installed_keg + def depends_on(one, two) + if one.any_installed_keg &.runtime_dependencies - &.any? { |d| d["full_name"] == b.full_name } + &.any? { |dependency| dependency["full_name"] == two.full_name } 1 else - a <=> b + one <=> two end end private_class_method :depends_on diff --git a/Library/Homebrew/version.rb b/Library/Homebrew/version.rb index e665bd6d0b..625de73440 100644 --- a/Library/Homebrew/version.rb +++ b/Library/Homebrew/version.rb @@ -653,9 +653,9 @@ class Version private - sig { params(a: Integer, b: Integer).returns(Integer) } - def max(a, b) - (a > b) ? a : b + sig { params(first: Integer, second: Integer).returns(Integer) } + def max(first, second) + (first > second) ? first : second end sig { returns(T::Array[Token]) }