audit: add rules for naming

- restrict old names as names of new formulae
- warn about dependencies on old names
This commit is contained in:
Vlad Shablinsky 2015-08-09 14:48:12 +03:00 committed by Mike McQuaid
parent ae9bf4aaaa
commit 556ab3bcd6

View File

@ -6,6 +6,7 @@ require "official_taps"
require "tap_migrations" require "tap_migrations"
require "cmd/search" require "cmd/search"
require "date" require "date"
require "formula_renames"
module Homebrew module Homebrew
def audit def audit
@ -229,6 +230,11 @@ class FormulaAuditor
return return
end end
if FORMULA_RENAMES.key? name
problem "'#{name}' is reserved as the old name of #{FORMULA_RENAMES[name]}"
return
end
if !formula.core_formula? && Formula.core_names.include?(name) if !formula.core_formula? && Formula.core_names.include?(name)
problem "Formula name conflicts with existing core formula." problem "Formula name conflicts with existing core formula."
return return
@ -270,6 +276,10 @@ class FormulaAuditor
next next
end end
if FORMULA_RENAMES[dep.name] == dep_f.name
problem "Dependency '#{dep.name}' was renamed; use newname '#{dep_f.name}'."
end
if @@aliases.include?(dep.name) if @@aliases.include?(dep.name)
problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'." problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'."
end end