From 556ab3bcd6125e22506bb8845576c73a4330f14f Mon Sep 17 00:00:00 2001 From: Vlad Shablinsky Date: Sun, 9 Aug 2015 14:48:12 +0300 Subject: [PATCH] audit: add rules for naming - restrict old names as names of new formulae - warn about dependencies on old names --- Library/Homebrew/cmd/audit.rb | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index 5af7792b2a..5417313b0e 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -6,6 +6,7 @@ require "official_taps" require "tap_migrations" require "cmd/search" require "date" +require "formula_renames" module Homebrew def audit @@ -229,6 +230,11 @@ class FormulaAuditor return end + if FORMULA_RENAMES.key? name + problem "'#{name}' is reserved as the old name of #{FORMULA_RENAMES[name]}" + return + end + if !formula.core_formula? && Formula.core_names.include?(name) problem "Formula name conflicts with existing core formula." return @@ -270,6 +276,10 @@ class FormulaAuditor next end + if FORMULA_RENAMES[dep.name] == dep_f.name + problem "Dependency '#{dep.name}' was renamed; use newname '#{dep_f.name}'." + end + if @@aliases.include?(dep.name) problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'." end