admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: whitelist bash-completion@* to use conflicts_with

Browse Source 
this is necessary because they install conflicting scripts into
HOMEBREW_PREFIX/etc/profile.d
This commit is contained in:
JCount 2017-03-05 14:19:32 -05:00
parent 43bfaa19f1
commit 4e50562424
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Library/Homebrew/dev-cmd/audit.rb
View File

@ -532,8 +532,11 @@ class FormulaAuditor
end end
end end
versioned_conflicts_whitelist = %w[node@ bash-completion@]
return unless formula.conflicts.any? && formula.versioned_formula? return unless formula.conflicts.any? && formula.versioned_formula?
return if formula.name.start_with? "node@" versioned_conflicts_whitelist.each { |c|
return if formula.name.start_with? c }
problem <<-EOS problem <<-EOS
Versioned formulae should not use `conflicts_with`. Versioned formulae should not use `conflicts_with`.
Use `keg_only :versioned_formula` instead. Use `keg_only :versioned_formula` instead.