From 4e50562424e246743b117167c732dc3988f561d2 Mon Sep 17 00:00:00 2001 From: JCount Date: Sun, 5 Mar 2017 14:19:32 -0500 Subject: [PATCH] audit: whitelist bash-completion@* to use conflicts_with this is necessary because they install conflicting scripts into HOMEBREW_PREFIX/etc/profile.d --- Library/Homebrew/dev-cmd/audit.rb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index d18e3b821f..30f39485a7 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -532,8 +532,11 @@ class FormulaAuditor end end + versioned_conflicts_whitelist = %w[node@ bash-completion@] + return unless formula.conflicts.any? && formula.versioned_formula? - return if formula.name.start_with? "node@" + versioned_conflicts_whitelist.each { |c| + return if formula.name.start_with? c } problem <<-EOS Versioned formulae should not use `conflicts_with`. Use `keg_only :versioned_formula` instead.