admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

cli/named_args: address review feedback

Browse Source 
- use `T.cast` to avoid unnecessary error handling with Sorbet
- avoid using dashes in terminal output to make piping easier
This commit is contained in:
apainintheneck 2024-05-08 18:13:35 -07:00
parent 60149fb5de
commit 3dcb26072b
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/cli/named_args.rb
View File

@ -107,13 +107,7 @@ module Homebrew
def to_formulae_and_casks_with_taps def to_formulae_and_casks_with_taps
formulae_and_casks_with_taps, formulae_and_casks_without_taps = formulae_and_casks_with_taps, formulae_and_casks_without_taps =
to_formulae_and_casks.partition do |formula_or_cask| to_formulae_and_casks.partition do |formula_or_cask|
case formula_or_cask T.cast(formula_or_cask, T.any(Formula, Cask::Cask)).tap&.installed?
when Formula, Cask::Cask
formula_or_cask.tap&.installed?
else
# TODO: Refactor methods so that Sorbet can tell that this is unreachable.
raise ArgumentError, "Not a formula or cask: #{formula_or_cask.class}"
end
end end
return formulae_and_casks_with_taps if formulae_and_casks_without_taps.blank? return formulae_and_casks_with_taps if formulae_and_casks_without_taps.blank?
@ -125,7 +119,7 @@ module Homebrew
odie <<~ERROR odie <<~ERROR
These #{types.join(" and ")} are not in any locally installed taps! These #{types.join(" and ")} are not in any locally installed taps!
- #{formulae_and_casks_without_taps.sort_by(&:to_s).join("\n- ")} #{formulae_and_casks_without_taps.sort_by(&:to_s).join("\n ")}
You may need to run `brew tap` to install additional taps. You may need to run `brew tap` to install additional taps.
ERROR ERROR