From 3dcb26072b1b96cbd3ae94f8361e7d0f983e630c Mon Sep 17 00:00:00 2001 From: apainintheneck Date: Wed, 8 May 2024 18:13:35 -0700 Subject: [PATCH] cli/named_args: address review feedback - use `T.cast` to avoid unnecessary error handling with Sorbet - avoid using dashes in terminal output to make piping easier --- Library/Homebrew/cli/named_args.rb | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/Library/Homebrew/cli/named_args.rb b/Library/Homebrew/cli/named_args.rb index 7ab9fe1a0b..c92693a87e 100644 --- a/Library/Homebrew/cli/named_args.rb +++ b/Library/Homebrew/cli/named_args.rb @@ -107,13 +107,7 @@ module Homebrew def to_formulae_and_casks_with_taps formulae_and_casks_with_taps, formulae_and_casks_without_taps = to_formulae_and_casks.partition do |formula_or_cask| - case formula_or_cask - when Formula, Cask::Cask - formula_or_cask.tap&.installed? - else - # TODO: Refactor methods so that Sorbet can tell that this is unreachable. - raise ArgumentError, "Not a formula or cask: #{formula_or_cask.class}" - end + T.cast(formula_or_cask, T.any(Formula, Cask::Cask)).tap&.installed? end return formulae_and_casks_with_taps if formulae_and_casks_without_taps.blank? @@ -125,7 +119,7 @@ module Homebrew odie <<~ERROR These #{types.join(" and ")} are not in any locally installed taps! - - #{formulae_and_casks_without_taps.sort_by(&:to_s).join("\n- ")} + #{formulae_and_casks_without_taps.sort_by(&:to_s).join("\n ")} You may need to run `brew tap` to install additional taps. ERROR