admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #10894 from reitermarkus/mandatory-livecheck

Browse Source 
Make `livecheck` audit mandatory for versioned casks.
This commit is contained in:
Markus Reiter 2021-03-23 01:34:00 +01:00 committed by GitHub
commit 3c6a7b39e2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Library/Homebrew/cask/audit.rb
View File

@ -546,12 +546,20 @@ module Cask
def check_livecheck_version def check_livecheck_version
return unless appcast? return unless appcast?
return unless cask.livecheckable?
return if cask.livecheck.skip? return if cask.livecheck.skip?
return if cask.version.latest? return if cask.version.latest?
latest_version = Homebrew::Livecheck.latest_version(cask)&.fetch(:latest) latest_version = Homebrew::Livecheck.latest_version(cask)&.fetch(:latest)
return if cask.version.to_s == latest_version.to_s if cask.version.to_s == latest_version.to_s
if cask.appcast
add_error "Version '#{latest_version}' was automatically detected by livecheck; " \
"the appcast should be removed."
end
return
end
return if cask.appcast && !cask.livecheckable?
add_error "Version '#{cask.version}' differs from '#{latest_version}' retrieved by livecheck." add_error "Version '#{cask.version}' differs from '#{latest_version}' retrieved by livecheck."
end end