From 41fec9959184c97cb1f8503c4fdb301a2ae22a4d Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Sat, 20 Mar 2021 23:38:20 +0100 Subject: [PATCH] Make `livecheck` audit mandatory for versioned casks. --- Library/Homebrew/cask/audit.rb | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cask/audit.rb b/Library/Homebrew/cask/audit.rb index 2fec78dd1e..f17dffa89c 100644 --- a/Library/Homebrew/cask/audit.rb +++ b/Library/Homebrew/cask/audit.rb @@ -542,12 +542,20 @@ module Cask def check_livecheck_version return unless appcast? - return unless cask.livecheckable? return if cask.livecheck.skip? return if cask.version.latest? latest_version = Homebrew::Livecheck.latest_version(cask)&.fetch(:latest) - return if cask.version.to_s == latest_version.to_s + if cask.version.to_s == latest_version.to_s + if cask.appcast + add_error "Version '#{latest_version}' was automatically detected by livecheck; " \ + "the appcast should be removed." + end + + return + end + + return if cask.appcast && !cask.livecheckable? add_error "Version '#{cask.version}' differs from '#{latest_version}' retrieved by livecheck." end