admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

If installed but not linked, say so

Browse Source 
Rationale: if ack is unlinked but installed, typing ack does nothing, but then user tries to install and it says it is already installed. What gives? The user thinks.

Formula ending up unlinked can happen due to failures during the link phase and we recommend unlinking formula for conflicts. So common enough to justify this amendment.
This commit is contained in:
Max Howell 2012-08-23 09:02:24 -04:00
parent 20ce16a3ff
commit 336c4d1b05
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/formula_installer.rb
View File

@ -24,7 +24,9 @@ class FormulaInstaller
def check_install_sanity
if f.installed?
raise CannotInstallFormulaError, "#{f}-#{f.installed_version} already installed"
msg = "#{f}-#{f.installed_version} already installed"
msg << ", it's just not linked" if not f.linked_keg.symlink? and not f.keg_only?
raise CannotInstallFormulaError, msg
end
# Building head-only without --HEAD is an error