From 336c4d1b05df9db2e13ffe88607f5e44493f3b8f Mon Sep 17 00:00:00 2001 From: Max Howell Date: Thu, 23 Aug 2012 09:02:24 -0400 Subject: [PATCH] If installed but not linked, say so Rationale: if ack is unlinked but installed, typing ack does nothing, but then user tries to install and it says it is already installed. What gives? The user thinks. Formula ending up unlinked can happen due to failures during the link phase and we recommend unlinking formula for conflicts. So common enough to justify this amendment. --- Library/Homebrew/formula_installer.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb index 8e082a7ced..6e1f596338 100644 --- a/Library/Homebrew/formula_installer.rb +++ b/Library/Homebrew/formula_installer.rb @@ -24,7 +24,9 @@ class FormulaInstaller def check_install_sanity if f.installed? - raise CannotInstallFormulaError, "#{f}-#{f.installed_version} already installed" + msg = "#{f}-#{f.installed_version} already installed" + msg << ", it's just not linked" if not f.linked_keg.symlink? and not f.keg_only? + raise CannotInstallFormulaError, msg end # Building head-only without --HEAD is an error