admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: ensure dependencies don't use options.

Browse Source 
Option dependencies are nasty as they cause unnecessary builds from
source.
This commit is contained in:
Mike McQuaid 2017-04-21 13:06:29 +01:00
parent 6e1faf5b88
commit 3011cbac34
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/dev-cmd/audit.rb
View File

@ -1028,11 +1028,15 @@ class FormulaAuditor
end end
if line =~ /depends_on :tex/ if line =~ /depends_on :tex/
problem ":tex is deprecated." problem ":tex is deprecated"
end end
if line =~ /depends_on\s+['"].+['"]\s+=>\s+:(lua|perl|python|ruby)(\d*)/ if line =~ /depends_on\s+['"](.+)['"]\s+=>\s+:(lua|perl|python|ruby)(\d*)/
problem "Formulae should vendor #{$1} modules rather than use `depends_on ... => :#{$1}#{$2}`." problem "#{$2} modules should be vendored rather than use deprecated `depends_on \"#{$1}\" => :#{$2}#{$3}`"
end
if line =~ /depends_on\s+['"](.+)['"]\s+=>\s+.*['"](.+)['"]/
problem "Dependency #{$1} should not use option #{$2}"
end end
# Commented-out depends_on # Commented-out depends_on