From 3011cbac34334c37eba20cbf06fe7942522602f6 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Fri, 21 Apr 2017 13:06:29 +0100 Subject: [PATCH] audit: ensure dependencies don't use options. Option dependencies are nasty as they cause unnecessary builds from source. --- Library/Homebrew/dev-cmd/audit.rb | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index 4871cc8b2d..7b0b2b9119 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -1028,11 +1028,15 @@ class FormulaAuditor end if line =~ /depends_on :tex/ - problem ":tex is deprecated." + problem ":tex is deprecated" end - if line =~ /depends_on\s+['"].+['"]\s+=>\s+:(lua|perl|python|ruby)(\d*)/ - problem "Formulae should vendor #{$1} modules rather than use `depends_on ... => :#{$1}#{$2}`." + if line =~ /depends_on\s+['"](.+)['"]\s+=>\s+:(lua|perl|python|ruby)(\d*)/ + problem "#{$2} modules should be vendored rather than use deprecated `depends_on \"#{$1}\" => :#{$2}#{$3}`" + end + + if line =~ /depends_on\s+['"](.+)['"]\s+=>\s+.*['"](.+)['"]/ + problem "Dependency #{$1} should not use option #{$2}" end # Commented-out depends_on