admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Use regex in brew-audit and add path concat test.

Browse Source
This commit is contained in:
Adam Vandenberg 2010-07-12 10:34:12 -07:00
parent 984d0bd05d
commit 2bac03ef92
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
Library/Contributions/examples/brew-audit.rb
View File

@ -14,18 +14,25 @@ def ff
end
ff.each do |f|
text = ""
File.open(f.path, "r") { |afile| text = afile.read }
problems = []
unless `grep "# depends_on 'cmake'" "#{f.path}"`.strip.empty?
problems << " * Commented cmake support still in #{f.name}"
if /# depends_on 'cmake'/ =~ text
problems << " * Commented cmake support found."
end
unless `grep "\?use_mirror=" "#{f.path}"`.strip.empty?
problems << " * Remove 'use_mirror' from url for #{f.name}"
if /\?use_mirror=/ =~ text
problems << " * Remove 'use_mirror' from url."
end
if /(#\{\w+\s*\+\s*['"][^}]+\})/ =~ text
problems << " * Try not to concatenate paths in string interpolation:\n #{$1}"
end
unless problems.empty?
puts "#{f.name}:"
puts problems * '\n'
puts problems * "\n"
puts
end
end