From 2bac03ef92d747e8a8d254976d111f3409766e3d Mon Sep 17 00:00:00 2001 From: Adam Vandenberg Date: Mon, 12 Jul 2010 10:34:12 -0700 Subject: [PATCH] Use regex in brew-audit and add path concat test. --- Library/Contributions/examples/brew-audit.rb | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/Library/Contributions/examples/brew-audit.rb b/Library/Contributions/examples/brew-audit.rb index 2c5d3a80d4..50728693d2 100755 --- a/Library/Contributions/examples/brew-audit.rb +++ b/Library/Contributions/examples/brew-audit.rb @@ -14,18 +14,25 @@ def ff end ff.each do |f| + text = "" + File.open(f.path, "r") { |afile| text = afile.read } + problems = [] - unless `grep "# depends_on 'cmake'" "#{f.path}"`.strip.empty? - problems << " * Commented cmake support still in #{f.name}" + if /# depends_on 'cmake'/ =~ text + problems << " * Commented cmake support found." end - unless `grep "\?use_mirror=" "#{f.path}"`.strip.empty? - problems << " * Remove 'use_mirror' from url for #{f.name}" + if /\?use_mirror=/ =~ text + problems << " * Remove 'use_mirror' from url." + end + + if /(#\{\w+\s*\+\s*['"][^}]+\})/ =~ text + problems << " * Try not to concatenate paths in string interpolation:\n #{$1}" end unless problems.empty? puts "#{f.name}:" - puts problems * '\n' + puts problems * "\n" puts end end