Merge pull request #5490 from MikeMcQuaid/scons-audit

rubocops: remove scons audit.

Library/Homebrew/rubocops/text.rb

@@ -42,10 +42,6 @@ module RuboCop
             problem %q(use "xcodebuild *args" instead of "system 'xcodebuild', *args")
           end
 
-          find_method_with_args(body_node, :system, "scons") do
-            problem "use \"scons *args\" instead of \"system 'scons', *args\""
-          end
-
           find_method_with_args(body_node, :system, "go", "get") do
             problem "Do not use `go get`. Please ask upstream to implement Go vendoring"
           end

Library/Homebrew/test/rubocops/text_spec.rb

@@ -86,20 +86,6 @@ describe RuboCop::Cop::FormulaAudit::Text do
       RUBY
     end
 
-    it "When scons is executed" do
-      expect_offense(<<~RUBY)
-        class Foo < Formula
-          url "https://brew.sh/foo-1.0.tgz"
-          homepage "https://brew.sh"
-
-          def install
-            system "scons", "foo", "bar"
-            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use \"scons *args\" instead of \"system 'scons', *args\"
-          end
-        end
-      RUBY
-    end
-
     it "When plist_options are not defined when using a formula-defined plist", :ruby23 do
       expect_offense(<<~RUBY)
         class Foo < Formula