From b917cccf195abd365185d867c0db1cf578b85990 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Sun, 6 Jan 2019 14:41:37 +0000 Subject: [PATCH] rubocops: remove scons audit. This will be deprecated in #5477. --- Library/Homebrew/rubocops/text.rb | 4 ---- Library/Homebrew/test/rubocops/text_spec.rb | 14 -------------- 2 files changed, 18 deletions(-) diff --git a/Library/Homebrew/rubocops/text.rb b/Library/Homebrew/rubocops/text.rb index 1aefacca58..78cffd7115 100644 --- a/Library/Homebrew/rubocops/text.rb +++ b/Library/Homebrew/rubocops/text.rb @@ -42,10 +42,6 @@ module RuboCop problem %q(use "xcodebuild *args" instead of "system 'xcodebuild', *args") end - find_method_with_args(body_node, :system, "scons") do - problem "use \"scons *args\" instead of \"system 'scons', *args\"" - end - find_method_with_args(body_node, :system, "go", "get") do problem "Do not use `go get`. Please ask upstream to implement Go vendoring" end diff --git a/Library/Homebrew/test/rubocops/text_spec.rb b/Library/Homebrew/test/rubocops/text_spec.rb index 8cbcf97750..39507ba0fb 100644 --- a/Library/Homebrew/test/rubocops/text_spec.rb +++ b/Library/Homebrew/test/rubocops/text_spec.rb @@ -86,20 +86,6 @@ describe RuboCop::Cop::FormulaAudit::Text do RUBY end - it "When scons is executed" do - expect_offense(<<~RUBY) - class Foo < Formula - url "https://brew.sh/foo-1.0.tgz" - homepage "https://brew.sh" - - def install - system "scons", "foo", "bar" - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use \"scons *args\" instead of \"system 'scons', *args\" - end - end - RUBY - end - it "When plist_options are not defined when using a formula-defined plist", :ruby23 do expect_offense(<<~RUBY) class Foo < Formula