admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #5490 from MikeMcQuaid/scons-audit

Browse Source 
rubocops: remove scons audit.
This commit is contained in:
Mike McQuaid 2019-01-06 15:00:30 +00:00 committed by GitHub
commit 28e34d8af0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/rubocops/text.rb
View File

@ -42,10 +42,6 @@ module RuboCop
problem %q(use "xcodebuild *args" instead of "system 'xcodebuild', *args") problem %q(use "xcodebuild *args" instead of "system 'xcodebuild', *args")
end end
find_method_with_args(body_node, :system, "scons") do
problem "use \"scons *args\" instead of \"system 'scons', *args\""
end
find_method_with_args(body_node, :system, "go", "get") do find_method_with_args(body_node, :system, "go", "get") do
problem "Do not use `go get`. Please ask upstream to implement Go vendoring" problem "Do not use `go get`. Please ask upstream to implement Go vendoring"
end end

14
Library/Homebrew/test/rubocops/text_spec.rb
View File

@ -86,20 +86,6 @@ describe RuboCop::Cop::FormulaAudit::Text do
RUBY RUBY
end end
it "When scons is executed" do
expect_offense(<<~RUBY)
class Foo < Formula
url "https://brew.sh/foo-1.0.tgz"
homepage "https://brew.sh"
def install
system "scons", "foo", "bar"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^ use \"scons *args\" instead of \"system 'scons', *args\"
end
end
RUBY
end
it "When plist_options are not defined when using a formula-defined plist", :ruby23 do it "When plist_options are not defined when using a formula-defined plist", :ruby23 do
expect_offense(<<~RUBY) expect_offense(<<~RUBY)
class Foo < Formula class Foo < Formula