admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

BundleVersion: Replace Nokogiri with REXML

Browse Source
This commit is contained in:
Sam Ford 2021-06-25 18:42:59 -04:00
parent aa14e48f4e
commit 282c71d275
No known key found for this signature in database
GPG Key ID: 95209E46C7FFDEFE
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Library/Homebrew/bundle_version.rb
View File

@ -30,15 +30,15 @@ module Homebrew
sig { params(package_info_path: Pathname).returns(T.nilable(T.attached_class)) } sig { params(package_info_path: Pathname).returns(T.nilable(T.attached_class)) }
def self.from_package_info(package_info_path) def self.from_package_info(package_info_path)
Homebrew.install_bundler_gems! require "rexml/document"
require "nokogiri"
xml = Nokogiri::XML(package_info_path.read) xml = REXML::Document.new(package_info_path.read)
bundle_id = xml.xpath("//pkg-info//bundle-version//bundle").first&.attr("id") bundle_version_bundle = xml.get_elements("//pkg-info//bundle-version//bundle").first
return unless bundle_id bundle_id = bundle_version_bundle["id"] if bundle_version_bundle
return if bundle_id.blank?
bundle = xml.xpath("//pkg-info//bundle").find { |b| b["id"] == bundle_id } bundle = xml.get_elements("//pkg-info//bundle").find { |b| b["id"] == bundle_id }
return unless bundle return unless bundle
short_version = bundle["CFBundleShortVersionString"] short_version = bundle["CFBundleShortVersionString"]