From 282c71d275a5bc11f4bb1f284f82a83742629d26 Mon Sep 17 00:00:00 2001 From: Sam Ford <1584702+samford@users.noreply.github.com> Date: Fri, 25 Jun 2021 18:42:59 -0400 Subject: [PATCH] BundleVersion: Replace Nokogiri with REXML --- Library/Homebrew/bundle_version.rb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Library/Homebrew/bundle_version.rb b/Library/Homebrew/bundle_version.rb index 8bf70d76ea..92c522659a 100644 --- a/Library/Homebrew/bundle_version.rb +++ b/Library/Homebrew/bundle_version.rb @@ -30,15 +30,15 @@ module Homebrew sig { params(package_info_path: Pathname).returns(T.nilable(T.attached_class)) } def self.from_package_info(package_info_path) - Homebrew.install_bundler_gems! - require "nokogiri" + require "rexml/document" - xml = Nokogiri::XML(package_info_path.read) + xml = REXML::Document.new(package_info_path.read) - bundle_id = xml.xpath("//pkg-info//bundle-version//bundle").first&.attr("id") - return unless bundle_id + bundle_version_bundle = xml.get_elements("//pkg-info//bundle-version//bundle").first + bundle_id = bundle_version_bundle["id"] if bundle_version_bundle + return if bundle_id.blank? - bundle = xml.xpath("//pkg-info//bundle").find { |b| b["id"] == bundle_id } + bundle = xml.get_elements("//pkg-info//bundle").find { |b| b["id"] == bundle_id } return unless bundle short_version = bundle["CFBundleShortVersionString"]