admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #6133 from zbeekman/exception-for-veclibfort-accelerate-audit

Browse Source 
Add exception for veclibfort linking to Accelerate
This commit is contained in:
Mike McQuaid 2019-05-14 22:11:57 +01:00 committed by GitHub
commit 24f5e6953d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Library/Homebrew/dev-cmd/bump-revision.rb
View File

@ -15,9 +15,9 @@ module Homebrew
present, "revision 1" will be added.
EOS
switch "-n", "--dry-run",
description: "Print what would be done rather than doing it."
description: "Print what would be done rather than doing it."
flag "--message=",
description: "Append the provided <message> to the default commit message."
description: "Append the provided <message> to the default commit message."
switch :force
switch :quiet
@ -76,7 +76,7 @@ module Homebrew
else
formula.path.parent.cd do
safe_system "git", "commit", "--no-edit", "--verbose",
"--message=#{message}", "--", formula.path
"--message=#{message}", "--", formula.path
end
end
end

4
Library/Homebrew/extend/os/mac/formula_cellar_checks.rb
View File

@ -51,6 +51,7 @@ module FormulaCellarChecks
def check_accelerate_framework_links
return unless @core_tap
return unless formula.prefix.directory?
return if formula.name == "veclibfort" # veclibfort exists to wrap accelerate
keg = Keg.new(formula.prefix)
system_accelerate = keg.mach_o_files.select do |obj|
@ -63,7 +64,8 @@ module FormulaCellarChecks
object files were linked against system Accelerate
These object files were linked against the outdated system Accelerate framework.
Core tap formulae should link against OpenBLAS instead.
Adding `depends_on "openblas"` to the formula may help.
Removing `depends_on "veclibfort" and/or adding `depends_on "openblas"` to the
formula may help.
#{system_accelerate * "\n "}
EOS
end