From b52e23c3ff0c5eae96410e7642afab187a56e788 Mon Sep 17 00:00:00 2001 From: Izaak Beekman Date: Tue, 14 May 2019 12:03:06 -0400 Subject: [PATCH 1/2] Fix audit errors in dev-cmd/bump-revision.rb - Method alignment was bad across line break in 3 places. --- Library/Homebrew/dev-cmd/bump-revision.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/dev-cmd/bump-revision.rb b/Library/Homebrew/dev-cmd/bump-revision.rb index 5c94e5871c..4141eb6469 100644 --- a/Library/Homebrew/dev-cmd/bump-revision.rb +++ b/Library/Homebrew/dev-cmd/bump-revision.rb @@ -15,9 +15,9 @@ module Homebrew present, "revision 1" will be added. EOS switch "-n", "--dry-run", - description: "Print what would be done rather than doing it." + description: "Print what would be done rather than doing it." flag "--message=", - description: "Append the provided to the default commit message." + description: "Append the provided to the default commit message." switch :force switch :quiet @@ -76,7 +76,7 @@ module Homebrew else formula.path.parent.cd do safe_system "git", "commit", "--no-edit", "--verbose", - "--message=#{message}", "--", formula.path + "--message=#{message}", "--", formula.path end end end From 056a2d41fd05a8a7b724e890f4718466aa1173cb Mon Sep 17 00:00:00 2001 From: Izaak Beekman Date: Tue, 14 May 2019 11:07:32 -0400 Subject: [PATCH 2/2] Add exception for veclibfort linking to Accelerate - veclibfort exists soley to wrap Apple's accelerate and provide BLAS/LAPACK access to Accelerate - Improve the help message for that audit to mention veclibfort --- Library/Homebrew/extend/os/mac/formula_cellar_checks.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/extend/os/mac/formula_cellar_checks.rb b/Library/Homebrew/extend/os/mac/formula_cellar_checks.rb index 94317d625f..b0bc68711f 100644 --- a/Library/Homebrew/extend/os/mac/formula_cellar_checks.rb +++ b/Library/Homebrew/extend/os/mac/formula_cellar_checks.rb @@ -51,6 +51,7 @@ module FormulaCellarChecks def check_accelerate_framework_links return unless @core_tap return unless formula.prefix.directory? + return if formula.name == "veclibfort" # veclibfort exists to wrap accelerate keg = Keg.new(formula.prefix) system_accelerate = keg.mach_o_files.select do |obj| @@ -63,7 +64,8 @@ module FormulaCellarChecks object files were linked against system Accelerate These object files were linked against the outdated system Accelerate framework. Core tap formulae should link against OpenBLAS instead. - Adding `depends_on "openblas"` to the formula may help. + Removing `depends_on "veclibfort" and/or adding `depends_on "openblas"` to the + formula may help. #{system_accelerate * "\n "} EOS end