rubocops/cask: No need for the first return if, [].each works OK

2023-03-20 23:49:03 +00:00 · 2023-03-20 23:49:03 +00:00 · 0b7bd81959
commit 0b7bd81959
parent ebdd408f99
1 changed files with 2 additions and 1 deletions
--- a/Library/Homebrew/rubocops/cask/no_overrides.rb
+++ b/Library/Homebrew/rubocops/cask/no_overrides.rb
@ -15,7 +15,8 @@ module RuboCop
        EOS

        def on_cask(cask_block)
-          return if (cask_stanzas = cask_block.toplevel_stanzas).empty?
+          cask_stanzas = cask_block.toplevel_stanzas
+
          # Skip if there are no `on_*` blocks.
          return unless (on_blocks = cask_stanzas.select { |s| ON_SYSTEM_METHODS.include?(s.stanza_name) }).any?