From 0b7bd81959cf7102c94db61941c78bb0c5ad1dcb Mon Sep 17 00:00:00 2001 From: Issy Long Date: Mon, 20 Mar 2023 23:49:03 +0000 Subject: [PATCH] rubocops/cask: No need for the first `return if`, `[].each` works OK --- Library/Homebrew/rubocops/cask/no_overrides.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/rubocops/cask/no_overrides.rb b/Library/Homebrew/rubocops/cask/no_overrides.rb index 822c8463f9..b6d76b4fb3 100644 --- a/Library/Homebrew/rubocops/cask/no_overrides.rb +++ b/Library/Homebrew/rubocops/cask/no_overrides.rb @@ -15,7 +15,8 @@ module RuboCop EOS def on_cask(cask_block) - return if (cask_stanzas = cask_block.toplevel_stanzas).empty? + cask_stanzas = cask_block.toplevel_stanzas + # Skip if there are no `on_*` blocks. return unless (on_blocks = cask_stanzas.select { |s| ON_SYSTEM_METHODS.include?(s.stanza_name) }).any?