admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Post-review clarifications

Browse Source
This commit is contained in:
Issy Long 2019-09-19 08:55:00 +01:00
parent d45f88c6ac
commit 0198011c20
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
docs/Homebrew-linuxbrew-core-Maintainer-Guide.md
View File

@ -285,15 +285,16 @@ lbrew-pull-bottle <PR-NUMBER> && brew squash-bottle-pr
For PRs where there have been force pushes or extra commits to fix the
build or fix bottling syntax, we can't `brew squash-bottle-pr` as we
must keep the fixes.
must keep the fixes. If the `# Build a bottle for Linuxbrew` line
still exists in the formula, remove it.
The `brew pull` command *publishes* the bottle to BinTray and verifies
that the SHA in the formula and the SHA of the downloaded file match.
To verify a bottle, the script downloads the bottle from BinTray - if
you're on an unstable connection, this may take a while or even time
out. Publishing the bottle means that it's available as the latest
version for users to download, so we have to be quick with pushing the
commits to `origin`.
version for users to download, so remember to push your commits to
`origin`.
If something goes wrong with the bottle pull and you don't want to
publish the bottle and push the commit, `git reset --hard