From 0198011c205f38cd776a38911b7e1a99906e97ac Mon Sep 17 00:00:00 2001 From: Issy Long Date: Thu, 19 Sep 2019 08:55:00 +0100 Subject: [PATCH] Post-review clarifications --- docs/Homebrew-linuxbrew-core-Maintainer-Guide.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/Homebrew-linuxbrew-core-Maintainer-Guide.md b/docs/Homebrew-linuxbrew-core-Maintainer-Guide.md index 4d0bd9c236..c8fa02549e 100644 --- a/docs/Homebrew-linuxbrew-core-Maintainer-Guide.md +++ b/docs/Homebrew-linuxbrew-core-Maintainer-Guide.md @@ -285,15 +285,16 @@ lbrew-pull-bottle && brew squash-bottle-pr For PRs where there have been force pushes or extra commits to fix the build or fix bottling syntax, we can't `brew squash-bottle-pr` as we -must keep the fixes. +must keep the fixes. If the `# Build a bottle for Linuxbrew` line +still exists in the formula, remove it. The `brew pull` command *publishes* the bottle to BinTray and verifies that the SHA in the formula and the SHA of the downloaded file match. To verify a bottle, the script downloads the bottle from BinTray - if you're on an unstable connection, this may take a while or even time out. Publishing the bottle means that it's available as the latest -version for users to download, so we have to be quick with pushing the -commits to `origin`. +version for users to download, so remember to push your commits to +`origin`. If something goes wrong with the bottle pull and you don't want to publish the bottle and push the commit, `git reset --hard