45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
49 lines
1.3 KiB
Ruby
49 lines
1.3 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "cask/artifact/relocated"
|
|
|
|
module Cask
|
|
class List
|
|
def self.list_casks(*casks, one: false, full_name: false, versions: false)
|
|
output = if casks.any?
|
|
casks.each do |cask|
|
|
raise CaskNotInstalledError, cask unless cask.installed?
|
|
end
|
|
else
|
|
Caskroom.casks
|
|
end
|
|
|
|
if one
|
|
puts output.map(&:to_s)
|
|
elsif full_name
|
|
puts output.map(&:full_name).sort(&tap_and_name_comparison)
|
|
elsif versions
|
|
puts output.map { format_versioned(_1) }
|
|
elsif !output.empty? && casks.any?
|
|
output.map { list_artifacts(_1) }
|
|
elsif !output.empty?
|
|
puts Formatter.columns(output.map(&:to_s))
|
|
end
|
|
end
|
|
|
|
def self.list_artifacts(cask)
|
|
cask.artifacts.group_by(&:class).sort_by { |klass, _| klass.english_name }.each do |klass, artifacts|
|
|
next if [Artifact::Uninstall, Artifact::Zap].include? klass
|
|
|
|
ohai klass.english_name
|
|
artifacts.each do |artifact|
|
|
puts artifact.summarize_installed if artifact.respond_to?(:summarize_installed)
|
|
next if artifact.respond_to?(:summarize_installed)
|
|
|
|
puts artifact
|
|
end
|
|
end
|
|
end
|
|
|
|
def self.format_versioned(cask)
|
|
"#{cask}#{cask.installed_version&.prepend(" ")}"
|
|
end
|
|
end
|
|
end
|