15f162c6ab
Let's use the disable date, if provided, and use 1 year after the deprecation date otherwise, to display a better message for the various outputs of deprecated package messages. Also, provide an internal API for this that can be used by Homebrew/actions.
94 lines
3.6 KiB
Ruby
94 lines
3.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "deprecate_disable"
|
|
|
|
RSpec.describe DeprecateDisable do
|
|
let(:deprecated_formula) do
|
|
instance_double(Formula, deprecated?: true, disabled?: false, deprecation_reason: :does_not_build,
|
|
deprecation_date: nil, disable_date: nil)
|
|
end
|
|
let(:disabled_formula) do
|
|
instance_double(Formula, deprecated?: false, disabled?: true, disable_reason: "is broken",
|
|
deprecation_date: nil, disable_date: nil)
|
|
end
|
|
let(:deprecated_cask) do
|
|
instance_double(Cask::Cask, deprecated?: true, disabled?: false, deprecation_reason: :discontinued,
|
|
deprecation_date: nil, disable_date: nil)
|
|
end
|
|
let(:disabled_cask) do
|
|
instance_double(Cask::Cask, deprecated?: false, disabled?: true, disable_reason: nil,
|
|
deprecation_date: nil, disable_date: nil)
|
|
end
|
|
|
|
before do
|
|
allow(deprecated_formula).to receive(:is_a?).with(Formula).and_return(true)
|
|
allow(deprecated_formula).to receive(:is_a?).with(Cask::Cask).and_return(false)
|
|
allow(disabled_formula).to receive(:is_a?).with(Formula).and_return(true)
|
|
allow(disabled_formula).to receive(:is_a?).with(Cask::Cask).and_return(false)
|
|
allow(deprecated_cask).to receive(:is_a?).with(Formula).and_return(false)
|
|
allow(deprecated_cask).to receive(:is_a?).with(Cask::Cask).and_return(true)
|
|
allow(disabled_cask).to receive(:is_a?).with(Formula).and_return(false)
|
|
allow(disabled_cask).to receive(:is_a?).with(Cask::Cask).and_return(true)
|
|
end
|
|
|
|
describe "::type" do
|
|
it "returns :deprecated if the formula is deprecated" do
|
|
expect(described_class.type(deprecated_formula)).to eq :deprecated
|
|
end
|
|
|
|
it "returns :disabled if the formula is disabled" do
|
|
expect(described_class.type(disabled_formula)).to eq :disabled
|
|
end
|
|
|
|
it "returns :deprecated if the cask is deprecated" do
|
|
expect(described_class.type(deprecated_cask)).to eq :deprecated
|
|
end
|
|
|
|
it "returns :disabled if the cask is disabled" do
|
|
expect(described_class.type(disabled_cask)).to eq :disabled
|
|
end
|
|
end
|
|
|
|
describe "::message" do
|
|
it "returns a deprecation message with a preset formula reason" do
|
|
expect(described_class.message(deprecated_formula))
|
|
.to eq "deprecated because it does not build!"
|
|
end
|
|
|
|
it "returns a disable message with a custom reason" do
|
|
expect(described_class.message(disabled_formula))
|
|
.to eq "disabled because it is broken!"
|
|
end
|
|
|
|
it "returns a deprecation message with a preset cask reason" do
|
|
expect(described_class.message(deprecated_cask))
|
|
.to eq "deprecated because it is discontinued upstream!"
|
|
end
|
|
|
|
it "returns a deprecation message with no reason" do
|
|
expect(described_class.message(disabled_cask))
|
|
.to eq "disabled!"
|
|
end
|
|
end
|
|
|
|
describe "::to_reason_string_or_symbol" do
|
|
it "returns the original string if it isn't a formula preset reason" do
|
|
expect(described_class.to_reason_string_or_symbol("discontinued", type: :formula)).to eq "discontinued"
|
|
end
|
|
|
|
it "returns the original string if it isn't a cask preset reason" do
|
|
expect(described_class.to_reason_string_or_symbol("does_not_build", type: :cask)).to eq "does_not_build"
|
|
end
|
|
|
|
it "returns a symbol if the original string is a formula preset reason" do
|
|
expect(described_class.to_reason_string_or_symbol("does_not_build", type: :formula))
|
|
.to eq :does_not_build
|
|
end
|
|
|
|
it "returns a symbol if the original string is a cask preset reason" do
|
|
expect(described_class.to_reason_string_or_symbol("discontinued", type: :cask))
|
|
.to eq :discontinued
|
|
end
|
|
end
|
|
end
|