45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
56 lines
2.1 KiB
Ruby
56 lines
2.1 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "rubocops/extend/formula_cop"
|
|
|
|
module RuboCop
|
|
module Cop
|
|
module FormulaAudit
|
|
# This cop audits versioned formulae for `conflicts_with`.
|
|
class Conflicts < FormulaCop
|
|
extend AutoCorrector
|
|
|
|
MSG = "Versioned formulae should not use `conflicts_with`. " \
|
|
"Use `keg_only :versioned_formula` instead."
|
|
|
|
sig { override.params(formula_nodes: FormulaNodes).void }
|
|
def audit_formula(formula_nodes)
|
|
return if (body_node = formula_nodes.body_node).nil?
|
|
|
|
find_method_calls_by_name(body_node, :conflicts_with).each do |conflicts_with_call|
|
|
next unless parameters(conflicts_with_call).last.respond_to? :values
|
|
|
|
reason = parameters(conflicts_with_call).last.values.first
|
|
offending_node(reason)
|
|
name = Regexp.new(@formula_name, Regexp::IGNORECASE)
|
|
reason_text = string_content(reason).sub(name, "")
|
|
first_word = reason_text.split.first
|
|
|
|
if reason_text.match?(/\A[A-Z]/)
|
|
problem "'#{first_word}' from the `conflicts_with` reason " \
|
|
"should be '#{first_word.downcase}'." do |corrector|
|
|
reason_text[0] = reason_text[0].downcase
|
|
corrector.replace(reason.source_range, "\"#{reason_text}\"")
|
|
end
|
|
end
|
|
next unless reason_text.end_with?(".")
|
|
|
|
problem "`conflicts_with` reason should not end with a period." do |corrector|
|
|
corrector.replace(reason.source_range, "\"#{reason_text.chop}\"")
|
|
end
|
|
end
|
|
|
|
return unless versioned_formula?
|
|
|
|
if !tap_style_exception?(:versioned_formulae_conflicts_allowlist) && method_called_ever?(body_node,
|
|
:conflicts_with)
|
|
problem MSG do |corrector|
|
|
corrector.replace(@offensive_node.source_range, "keg_only :versioned_formula")
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|