45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
109 lines
3.1 KiB
Ruby
109 lines
3.1 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "tab"
|
|
|
|
module Cask
|
|
class Tab < ::AbstractTab
|
|
attr_accessor :uninstall_flight_blocks, :uninstall_artifacts
|
|
|
|
# Instantiates a {Tab} for a new installation of a cask.
|
|
def self.create(cask)
|
|
tab = super
|
|
|
|
tab.tabfile = cask.metadata_main_container_path/FILENAME
|
|
tab.uninstall_flight_blocks = cask.uninstall_flight_blocks?
|
|
tab.runtime_dependencies = Tab.runtime_deps_hash(cask)
|
|
tab.source["version"] = cask.version.to_s
|
|
tab.source["path"] = cask.sourcefile_path.to_s
|
|
tab.uninstall_artifacts = cask.artifacts_list(uninstall_only: true)
|
|
|
|
tab
|
|
end
|
|
|
|
# Returns a {Tab} for an already installed cask,
|
|
# or a fake one if the cask is not installed.
|
|
def self.for_cask(cask)
|
|
path = cask.metadata_main_container_path/FILENAME
|
|
|
|
return from_file(path) if path.exist?
|
|
|
|
tab = empty
|
|
tab.source = {
|
|
"path" => cask.sourcefile_path.to_s,
|
|
"tap" => cask.tap&.name,
|
|
"tap_git_head" => cask.tap_git_head,
|
|
"version" => cask.version.to_s,
|
|
}
|
|
tab.uninstall_artifacts = cask.artifacts_list(uninstall_only: true)
|
|
|
|
tab
|
|
end
|
|
|
|
def self.empty
|
|
tab = super
|
|
tab.uninstall_flight_blocks = false
|
|
tab.uninstall_artifacts = []
|
|
tab.source["version"] = nil
|
|
|
|
tab
|
|
end
|
|
|
|
def self.runtime_deps_hash(cask)
|
|
cask_and_formula_dep_graph = ::Utils::TopologicalHash.graph_package_dependencies(cask)
|
|
cask_deps, formula_deps = cask_and_formula_dep_graph.values.flatten.uniq.partition do |dep|
|
|
dep.is_a?(Cask)
|
|
end
|
|
|
|
runtime_deps = {}
|
|
|
|
if cask_deps.any?
|
|
runtime_deps[:cask] = cask_deps.map do |dep|
|
|
{
|
|
"full_name" => dep.full_name,
|
|
"version" => dep.version.to_s,
|
|
"declared_directly" => cask.depends_on.cask.include?(dep.full_name),
|
|
}
|
|
end
|
|
end
|
|
|
|
if formula_deps.any?
|
|
runtime_deps[:formula] = formula_deps.map do |dep|
|
|
formula_to_dep_hash(dep, cask.depends_on.formula)
|
|
end
|
|
end
|
|
|
|
runtime_deps
|
|
end
|
|
|
|
def version
|
|
source["version"]
|
|
end
|
|
|
|
def to_json(*_args)
|
|
attributes = {
|
|
"homebrew_version" => homebrew_version,
|
|
"loaded_from_api" => loaded_from_api,
|
|
"uninstall_flight_blocks" => uninstall_flight_blocks,
|
|
"installed_as_dependency" => installed_as_dependency,
|
|
"installed_on_request" => installed_on_request,
|
|
"time" => time,
|
|
"runtime_dependencies" => runtime_dependencies,
|
|
"source" => source,
|
|
"arch" => arch,
|
|
"uninstall_artifacts" => uninstall_artifacts,
|
|
"built_on" => built_on,
|
|
}
|
|
|
|
JSON.pretty_generate(attributes)
|
|
end
|
|
|
|
def to_s
|
|
s = ["Installed"]
|
|
s << "using the formulae.brew.sh API" if loaded_from_api
|
|
s << Time.at(time).strftime("on %Y-%m-%d at %H:%M:%S") if time
|
|
s.join(" ")
|
|
end
|
|
end
|
|
end
|