45978435e7
- Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
52 lines
1.2 KiB
Ruby
52 lines
1.2 KiB
Ruby
# typed: true # rubocop:todo Sorbet/StrictSigil
|
|
# frozen_string_literal: true
|
|
|
|
require "cask/artifact/abstract_artifact"
|
|
|
|
module Cask
|
|
module Artifact
|
|
# Abstract superclass for block artifacts.
|
|
class AbstractFlightBlock < AbstractArtifact
|
|
def self.dsl_key
|
|
super.to_s.sub(/_block$/, "").to_sym
|
|
end
|
|
|
|
def self.uninstall_dsl_key
|
|
dsl_key.to_s.prepend("uninstall_").to_sym
|
|
end
|
|
|
|
attr_reader :directives
|
|
|
|
def initialize(cask, **directives)
|
|
super(cask)
|
|
@directives = directives
|
|
end
|
|
|
|
def install_phase(**)
|
|
abstract_phase(self.class.dsl_key)
|
|
end
|
|
|
|
def uninstall_phase(**)
|
|
abstract_phase(self.class.uninstall_dsl_key)
|
|
end
|
|
|
|
def summarize
|
|
directives.keys.map(&:to_s).join(", ")
|
|
end
|
|
|
|
private
|
|
|
|
def class_for_dsl_key(dsl_key)
|
|
namespace = self.class.name.to_s.sub(/::.*::.*$/, "")
|
|
self.class.const_get("#{namespace}::DSL::#{dsl_key.to_s.split("_").map(&:capitalize).join}")
|
|
end
|
|
|
|
def abstract_phase(dsl_key)
|
|
return if (block = directives[dsl_key]).nil?
|
|
|
|
class_for_dsl_key(dsl_key).new(cask).instance_eval(&block)
|
|
end
|
|
end
|
|
end
|
|
end
|